-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Document the "Other" entry in data summaries in Kibana guide #85575
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a minor suggestion around punctuation and using active voice, but otherwise, LGTM!
Also, can you add a screenshot that shows this?
@@ -228,6 +228,8 @@ To view the data field summary information, navigate to the field, then click *i | |||
[role="screenshot"] | |||
image::images/lens_data_info.png[Data summary window] | |||
|
|||
Sometimes documents have no data for the field inspected: *Lens* will show a "Other" entry to represent these documents in the distribution chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes documents have no data for the field inspected: *Lens* will show a "Other" entry to represent these documents in the distribution chart. | |
Sometimes documents have no data for the field inspected:. *Lens* shows an *Other* entry to represent these documents in the distribution chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a screenshot that shows this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the screenshot for it, but then dropped as I thought it was too much. Will add it back! 📸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wylieconlon knows better, but I don't think "Sometimes documents have no data for the field inspected: Lens shows an "Other" entry to represent these documents in the distribution chart." is 100% (pun intended) true - the field summary will only give you 10 entries at max, grouping everything else into "Other":
Ok, found out the 10 value in the server code. Will update on that side as well. |
[role="screenshot"] | ||
image::images/lens_data_info_other.png[Data summary window with Other] | ||
|
||
NOTE: because the distribution is based on single values, the sum of all the entries and "Other" may be above 100%, because entries in array values are counted as distinct values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick test and while Tim raises a good point in the issue you opened, this is not the case right now:
For this data:
POST testindex/_doc
{
"val": ["A", "B", "C"]
}
POST testindex/_doc
{
"val": ["D", "E", "F"]
}
POST testindex/_doc
{
"val": ["G", "H", "I"]
}
Right now it seems like this only caused by rounding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching up on this discussion: @flash1293 is right that it's only a rounding issue, not an issue with the underlying calculation. The size of "other" is based on the value_count
of the field minus the sum of all terms we get back, which is correct for array fields and regular fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we're updating this part of the docs, but I think it needs another round of updates for accuracy!
[role="screenshot"] | ||
image::images/lens_data_info_other.png[Data summary window with Other] | ||
|
||
NOTE: because the distribution is based on single values, the sum of all the entries and "Other" may be above 100%, because entries in array values are counted as distinct values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching up on this discussion: @flash1293 is right that it's only a rounding issue, not an issue with the underlying calculation. The size of "other" is based on the value_count
of the field minus the sum of all terms we get back, which is correct for array fields and regular fields.
@@ -228,6 +228,13 @@ To view the data field summary information, navigate to the field, then click *i | |||
[role="screenshot"] | |||
image::images/lens_data_info.png[Data summary window] | |||
|
|||
*Lens* inspects the top 10 values to build the value distribution: every other value, together with documents with no data for the inspected field, are shown with the "Other" entry in the distribution chart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is missing information about what happens for number/date fields: in both cases we do something more than just top 10. For numbers we show both top 10 and histogram. We show the histogram when the top 10 values are less than 10% of all the values.
…s by type and hardcoded stat values
I've revisited completely the data summary section to cover all the raised questions and feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Left a couple of tweaks that you can optionally take
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Co-authored-by: Wylie Conlon <[email protected]>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
…lastic#85575) * 📝 Address Other entry in data summaries * 👌 Integrated feedback from review * 📝 Add not about going beyong 100% with array values * 👌 Improved documentation for summaries * 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> Co-authored-by: Wylie Conlon <[email protected]>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…guide (#85575) (#86344) * 📝 Address Other entry in data summaries * 👌 Integrated feedback from review * 📝 Add not about going beyong 100% with array values * 👌 Improved documentation for summaries * 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> Co-authored-by: Wylie Conlon <[email protected]> Co-authored-by: Wylie Conlon <[email protected]>
…uide (#85575) (#86345) * 📝 Address Other entry in data summaries * 👌 Integrated feedback from review * 📝 Add not about going beyong 100% with array values * 👌 Improved documentation for summaries * 👌 Improved documentation for data summaries covering discussed aspects by type and hardcoded stat values * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> * Update docs/user/dashboard/dashboard.asciidoc Co-authored-by: Wylie Conlon <[email protected]> Co-authored-by: Wylie Conlon <[email protected]> Co-authored-by: Wylie Conlon <[email protected]>
Summary
Fix #81677
Since the issue has been created the Lens UI changed introducing the
Other
entry to fill the gap until 100% of the value. The missing bit was some documentation to cover the meaning of this special entry, provided by this PR.Checklist